On Fri, Apr 12, 2019 at 08:36:54AM +0000, Z.q. Hou wrote: > From: Hou Zhiqiang <[email protected]> > > Sometimes there is not a PCIe Endpoint stalled in the slot, > so do not exit when the PCIe link is not up. And degrade the > print level of link up info.
So what's the point of probing if the link does not initialize ? Lorenzo > Signed-off-by: Hou Zhiqiang <[email protected]> > Reviewed-by: Minghuan Lian <[email protected]> > Reviewed-by: Subrahmanya Lingappa <[email protected]> > --- > V5: > - Corrected and retouched the subject and changelog. > > drivers/pci/controller/pcie-mobiveil.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/pci/controller/pcie-mobiveil.c > b/drivers/pci/controller/pcie-mobiveil.c > index 1ee3ea2570c0..8dc87c7a600e 100644 > --- a/drivers/pci/controller/pcie-mobiveil.c > +++ b/drivers/pci/controller/pcie-mobiveil.c > @@ -560,7 +560,7 @@ static int mobiveil_bringup_link(struct mobiveil_pcie > *pcie) > usleep_range(LINK_WAIT_MIN, LINK_WAIT_MAX); > } > > - dev_err(&pcie->pdev->dev, "link never came up\n"); > + dev_info(&pcie->pdev->dev, "link never came up\n"); > > return -ETIMEDOUT; > } > @@ -926,10 +926,8 @@ static int mobiveil_pcie_probe(struct platform_device > *pdev) > bridge->swizzle_irq = pci_common_swizzle; > > ret = mobiveil_bringup_link(pcie); > - if (ret) { > + if (ret) > dev_info(dev, "link bring-up failed\n"); > - goto error; > - } > > /* setup the kernel resources for the newly added PCIe root bus */ > ret = pci_scan_root_bus_bridge(bridge); > -- > 2.17.1 >
