On Wed, Jun 12, 2019 at 1:10 PM Greg Kroah-Hartman <[email protected]> wrote: > > On Wed, Jun 12, 2019 at 12:58:19PM -0400, Joel Fernandes wrote: > > On Wed, Jun 12, 2019 at 05:35:13PM +0200, Greg Kroah-Hartman wrote: > > > When calling debugfs functions, there is no need to ever check the > > > return value. The function can work or not, but the code logic should > > > never do something different based on this. > > > > > > Cc: Qian Cai <[email protected]> > > > Cc: Thomas Gleixner <[email protected]> > > > Cc: Andrew Morton <[email protected]> > > > Cc: Waiman Long <[email protected]> > > > Cc: "Joel Fernandes (Google)" <[email protected]> > > > Cc: Zhong Jiang <[email protected]> > > > Cc: [email protected] > > > Signed-off-by: Greg Kroah-Hartman <[email protected]> > > > --- > > > lib/debugobjects.c | 14 ++------------ > > > 1 file changed, 2 insertions(+), 12 deletions(-) > > > > > > diff --git a/lib/debugobjects.c b/lib/debugobjects.c > > > index 55437fd5128b..2ac42286cd08 100644 > > > --- a/lib/debugobjects.c > > > +++ b/lib/debugobjects.c > > > @@ -850,26 +850,16 @@ static const struct file_operations > > > debug_stats_fops = { > > > > > > static int __init debug_objects_init_debugfs(void) > > > { > > > - struct dentry *dbgdir, *dbgstats; > > > + struct dentry *dbgdir; > > > > > > if (!debug_objects_enabled) > > > return 0; > > > > > > dbgdir = debugfs_create_dir("debug_objects", NULL); > > > - if (!dbgdir) > > > - return -ENOMEM; > > > > > > - dbgstats = debugfs_create_file("stats", 0444, dbgdir, NULL, > > > - &debug_stats_fops); > > > - if (!dbgstats) > > > - goto err; > > > + debugfs_create_file("stats", 0444, dbgdir, NULL, &debug_stats_fops); > > > > > > One weirdness is, if dbgdir is ever NULL, then debugfs_create_file() may end > > up creating the stats file in the root. > > Yes, but dbgdir can not be NULL.
Makes sense, thanks for clarification, - Joel
