On Friday 31 August 2007 7:10:00 am Satyam Sharma wrote: > Hi Rob, > > On Thu, 30 Aug 2007, Rob Landley wrote: > > On Thursday 30 August 2007 2:04:37 pm Randy Dunlap wrote: > > > Please use the expected (canonical) patch format. > > > > > > See Documentation/SubmittingPatches: > > > 14) The canonical patch format > > > > from Rob Landley <[EMAIL PROTECTED]> > > Signed-off-by: Rob Landley <[EMAIL PROTECTED]> > > > > ecryptfs.txt moved into filesystems, make 00-INDEX follow. > > That's still not quite right :-) What Randy meant is that the sign-off > must come /after/ the patch description:
Randy emailed me about it offline and I updated my wrapper script. I've always had a bit of a blind spot when it comes to filling out forms (I suck at bureaucracy), so I made a script to do it, currently: #!/bin/bash echo "From: Rob Landley <[EMAIL PROTECTED]>" echo echo "Signed-off-by: Rob Landley <[EMAIL PROTECTED]>" echo "---" echo cat $1 | diffstat echo cat $1 I note that the example uses "From:" but the summary refers to it as the "from" line with no capital letter or colon, and unix being case sensitive I reproduced the quoted string verbatim. (See "I suck at bureaucracy", above.) > [ All this is not too important, admittedly, but causes least amount of > processing time to be wasted on the recipient's end, and also does not > confuse scripts that may be used to extract patches (and git commit > command-line arguments) from mails automatically. ] If it's going to be parsed by a script, it might as well be generated by a script... I've got another dozen of these patches to send, but I'm waiting to see which ones Jesper Juhl has queued up first. :) (Between the two of us, we'll get this updated eventually...) Rob -- "One of my most productive days was throwing away 1000 lines of code." - Ken Thompson. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
