Hi all, Friendly ping:
Who can take this? Thanks -- Gustavo On 6/4/19 9:45 AM, Kees Cook wrote: > On Tue, Jun 04, 2019 at 09:17:37AM -0500, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >> where we are expecting to fall through. >> >> This patch fixes the following warning: >> >> drivers/mtd/nand/onenand/onenand_base.c: In function >> ‘onenand_check_features’: >> drivers/mtd/nand/onenand/onenand_base.c:3264:17: warning: this statement may >> fall through [-Wimplicit-fallthrough=] >> this->options |= ONENAND_HAS_NOP_1; >> drivers/mtd/nand/onenand/onenand_base.c:3265:2: note: here >> case ONENAND_DEVICE_DENSITY_4Gb: >> ^~~~ >> >> Warning level 3 was used: -Wimplicit-fallthrough=3 >> >> This patch is part of the ongoing efforts to enable >> -Wimplicit-fallthrough. >> >> Cc: Jonathan Bakker <[email protected]> >> Signed-off-by: Gustavo A. R. Silva <[email protected]> > > Reviewed-by: Kees Cook <[email protected]> > > -Kees > >> --- >> drivers/mtd/nand/onenand/onenand_base.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/mtd/nand/onenand/onenand_base.c >> b/drivers/mtd/nand/onenand/onenand_base.c >> index ba46d0cf60a1..bdb5f4733d28 100644 >> --- a/drivers/mtd/nand/onenand/onenand_base.c >> +++ b/drivers/mtd/nand/onenand/onenand_base.c >> @@ -3262,6 +3262,7 @@ static void onenand_check_features(struct mtd_info >> *mtd) >> switch (density) { >> case ONENAND_DEVICE_DENSITY_8Gb: >> this->options |= ONENAND_HAS_NOP_1; >> + /* fall through */ >> case ONENAND_DEVICE_DENSITY_4Gb: >> if (ONENAND_IS_DDP(this)) >> this->options |= ONENAND_HAS_2PLANE; >> -- >> 2.21.0 >> >
