On Wed, Jun 26, 2019 at 5:04 PM Greg KH <[email protected]> wrote: > > On Wed, Jun 26, 2019 at 03:48:58PM -0700, Tri Vo wrote: > > On Tue, Jun 25, 2019 at 6:33 PM Tri Vo <[email protected]> wrote: > > > > > > On Tue, Jun 25, 2019 at 6:12 PM Greg KH <[email protected]> > > > wrote: > > > > > > > > On Tue, Jun 25, 2019 at 05:54:49PM -0700, Tri Vo wrote: > > > > > Embedding a struct kobject into struct wakeup_source changes lifetime > > > > > requirements on the latter. To that end, change deallocation of struct > > > > > wakeup_source using kfree to kobject_put(). > > > > > > > > Ick, are you sure you need a new kobject here? Why wouldn't a named > > > > attribute group work instead? That should keep this patch much smaller > > > > and simpler. > > > > > > Yeah, named attribute groups might be a much cleaner way to do this. > > > Let me investigate. > > > > Say, we read /sys/power/wakeup_sources/foo/active_count. > > What is "foo" here? You didn't include Documentation of the sysfs > files so it was pretty impossible to say what exactly your heirachy was > going to be in order to determine this :)
Sorry about that. I sent out a new version of the patch with updated documentation.
