On Mon, 2019-07-01 at 17:26 +0100, Colin King wrote: > From: Colin Ian King <[email protected]> > > The comparison of the u32 variable wgds_tbl_idx with less than zero is > always going to be false because it is unsigned. Fix this by making > wgds_tbl_idx a plain signed int. > > Addresses-Coverity: ("Unsigned compared against 0") > Fixes: 4fd445a2c855 ("iwlwifi: mvm: Add log information about SAR status") > Signed-off-by: Colin Ian King <[email protected]> > --- > drivers/net/wireless/intel/iwlwifi/mvm/nvm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/nvm.c > b/drivers/net/wireless/intel/iwlwifi/mvm/nvm.c > index 719f793b3487..a9bb43a2f27b 100644 > --- a/drivers/net/wireless/intel/iwlwifi/mvm/nvm.c > +++ b/drivers/net/wireless/intel/iwlwifi/mvm/nvm.c > @@ -620,7 +620,7 @@ void iwl_mvm_rx_chub_update_mcc(struct iwl_mvm *mvm, > enum iwl_mcc_source src; > char mcc[3]; > struct ieee80211_regdomain *regd; > - u32 wgds_tbl_idx; > + int wgds_tbl_idx; > > lockdep_assert_held(&mvm->mutex);
Thanks, Colin! I applied this to our internal tree and it will reach the mainline following our normal upstreaming process. -- Cheers, Luca.
