On Fri, Apr 12, 2019 at 08:35:30AM +0000, Z.q. Hou wrote: > From: Hou Zhiqiang <[email protected]> > > This patch corrects the returned error number by convention, > and removes an unnecessary error check.
Two distinct changes, two patches, please split and repost. Lorenzo > Signed-off-by: Hou Zhiqiang <[email protected]> > Reviewed-by: Minghuan Lian <[email protected]> > Reviewed-by: Subrahmanya Lingappa <[email protected]> > --- > V5: > - Corrected and retouched the subject and changelog. > > drivers/pci/controller/pcie-mobiveil.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/pci/controller/pcie-mobiveil.c > b/drivers/pci/controller/pcie-mobiveil.c > index b87471f08a40..563210e731d3 100644 > --- a/drivers/pci/controller/pcie-mobiveil.c > +++ b/drivers/pci/controller/pcie-mobiveil.c > @@ -819,7 +819,7 @@ static int mobiveil_pcie_init_irq_domain(struct > mobiveil_pcie *pcie) > > if (!pcie->intx_domain) { > dev_err(dev, "Failed to get a INTx IRQ domain\n"); > - return -ENODEV; > + return -ENOMEM; > } > > raw_spin_lock_init(&pcie->intx_mask_lock); > @@ -845,11 +845,9 @@ static int mobiveil_pcie_probe(struct platform_device > *pdev) > /* allocate the PCIe port */ > bridge = devm_pci_alloc_host_bridge(dev, sizeof(*pcie)); > if (!bridge) > - return -ENODEV; > + return -ENOMEM; > > pcie = pci_host_bridge_priv(bridge); > - if (!pcie) > - return -ENOMEM; > > pcie->pdev = pdev; > > @@ -866,7 +864,7 @@ static int mobiveil_pcie_probe(struct platform_device > *pdev) > &pcie->resources, &iobase); > if (ret) { > dev_err(dev, "Getting bridge resources failed\n"); > - return -ENOMEM; > + return ret; > } > > /* > -- > 2.17.1 >
