On Wed, Jul 03, 2019 at 03:39:54PM +0200, Johannes Berg wrote: > On Tue, 2019-07-02 at 13:50 +0200, Michal Kubecek wrote: > > > > +static bool ethnl_ok __read_mostly; > > Not sure it makes a big difference, but it could probably be > __ro_after_init instead?
Yes, that's more fitting; the flag is initialized to false, changes to true once ethtool netlink is ready and never changes back. I wasn't aware of __ro_after_init annotation. Michal
