From: Peng Li <lipeng...@huawei.com>

The value of param type is always not changed in
hclgevf_bind_ring_to_vector, move the assignment to
front of "for {}" can reduce the redundant assignment.

Signed-off-by: Peng Li <lipeng...@huawei.com>
Signed-off-by: Huazhong Tan <tanhuazh...@huawei.com>
---
 drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c 
b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
index ff7e8cb..a13a0e1 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
@@ -994,6 +994,8 @@ static int hclgevf_bind_ring_to_vector(struct hnae3_handle 
*handle, bool en,
        u8 type;
 
        req = (struct hclge_mbx_vf_to_pf_cmd *)desc.data;
+       type = en ? HCLGE_MBX_MAP_RING_TO_VECTOR :
+               HCLGE_MBX_UNMAP_RING_TO_VECTOR;
 
        for (node = ring_chain; node; node = node->next) {
                int idx_offset = HCLGE_MBX_RING_MAP_BASIC_MSG_NUM +
@@ -1003,9 +1005,6 @@ static int hclgevf_bind_ring_to_vector(struct 
hnae3_handle *handle, bool en,
                        hclgevf_cmd_setup_basic_desc(&desc,
                                                     HCLGEVF_OPC_MBX_VF_TO_PF,
                                                     false);
-                       type = en ?
-                               HCLGE_MBX_MAP_RING_TO_VECTOR :
-                               HCLGE_MBX_UNMAP_RING_TO_VECTOR;
                        req->msg[0] = type;
                        req->msg[1] = vector_id;
                }
-- 
2.7.4

Reply via email to