From: Markus Elfring <[email protected]> Date: Fri, 5 Jul 2019 20:22:26 +0200
Avoid an extra function call by using a ternary operator instead of a conditional statement. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <[email protected]> --- drivers/mfd/asic3.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c index 83b18c998d6f..50f5368fb170 100644 --- a/drivers/mfd/asic3.c +++ b/drivers/mfd/asic3.c @@ -401,11 +401,10 @@ static int __init asic3_irq_probe(struct platform_device *pdev) irq_base = asic->irq_base; for (irq = irq_base; irq < irq_base + ASIC3_NR_IRQS; irq++) { - if (irq < asic->irq_base + ASIC3_NUM_GPIOS) - irq_set_chip(irq, &asic3_gpio_irq_chip); - else - irq_set_chip(irq, &asic3_irq_chip); - + irq_set_chip(irq, + (irq < asic->irq_base + ASIC3_NUM_GPIOS) + ? &asic3_gpio_irq_chip + : &asic3_irq_chip); irq_set_chip_data(irq, asic); irq_set_handler(irq, handle_level_irq); irq_clear_status_flags(irq, IRQ_NOREQUEST | IRQ_NOPROBE); -- 2.22.0
