On Wed, 3 Jul 2019 10:25:04 -0400 Steven Rostedt <[email protected]> wrote:
> On Wed, 3 Jul 2019 10:24:02 -0400 > Steven Rostedt <[email protected]> wrote: > > > On Wed, 3 Jul 2019 15:08:32 +0100 > > Catalin Marinas <[email protected]> wrote: > > > > > > > > +static int __init run_init_test_probes(void) > > > > +{ > > > > + if (run_kprobe_tests) > > > > + init_test_probes(); > > > > > > A return 0 here. > > > > Will update (would have triggered a failure on my test suite anyway ;-) > > > > > > > > > +} > > > > +module_init(run_init_test_probes); > > > > > > This does the trick. I prefer your fix as it leaves the arch code > > > unchanged. In case you need it: > > > > > > Tested-by: Catalin Marinas <[email protected]> > > > > > > > Masami, > > If you give me an Acked-by, I'll add it to my tree. Sorry for late reply, but I want to keep the test running right after initialization as the first user of kprobes at that timing, since other user can start using kprobes right after init_kprobes(). So this issue must be fixed in moving the init_kprobes() itself right after arch_initcall() (and that is subsys_initcall) Catalin, Mark, could you ensure the below patch can fix your issue? https://lore.kernel.org/lkml/[email protected]/ And if so, Steve, could you push above one (which seems already in your tree) to next as a fix? Thank you, -- Masami Hiramatsu <[email protected]>
