On Wed, 10 Jul 2019 11:49:31 +0200, Takashi Iwai wrote: > > On Wed, 10 Jul 2019 04:30:59 +0200, > Hariprasad Kelam wrote: > > > > This patch fixes below issue reported by coccicheck > > sound/pci/lx6464es/lx6464es.c:256:5-8: Unneeded variable: "err". Return > > "0" on line 258 > > > > We cannot change return value as its registered with snd_pcm_ops->close > > > > Signed-off-by: Hariprasad Kelam <[email protected]> > > Applied, thanks.
Well, looking at the description above again, I'd drop the text "We cannot change return value as its registered with snd_pcm_ops->close" because this is quite misleading. There is absolutely no need for changing the function return type. thanks, Takashi
