On Sat, Jul 13, 2019 at 01:26:45PM +0200, Luca Weiss wrote:
> Hi Brian,
> how about something like that (formatting is surely broken because I'm not
> sending this with git-send-email^^)?
>
> I'd says this should be work fine with all devices as all modes are defined
> in
> the device-specific dts but the reg and offset values are in the board dts.
> Should I also add a status = "disabled" to the reboot-mode node in the board
> dts?
>
> diff --git a/arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts b/arch/arm/boot/
> dts/qcom-msm8974-fairphone-fp2.dts
> index 643c57f84818..ff4a3e0aa746 100644
> --- a/arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts
> +++ b/arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts
> @@ -338,6 +338,16 @@
> };
> };
> };
> +
> + imem@fe805000 {
> + status = "okay";
> +
> + reboot-mode {
> + mode-normal = <0x77665501>;
> + mode-bootloader = <0x77665500>;
> + mode-recovery = <0x77665502>;
> + };
> + };
> };
>
> &spmi_bus {
> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-
> msm8974.dtsi
> index 45b5c8ef0374..1927430bded7 100644
> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
> @@ -1085,6 +1085,17 @@
> };
> };
> };
> +
> + imem@fe805000 {
> + status = "disabled";
> + compatible = "syscon", "simple-mfd";
> + reg = <0xfe805000 0x1000>;
> +
> + reboot-mode {
> + compatible = "syscon-reboot-mode";
> + offset = <0x65c>;
> + };
> + };
> };
>
> smd {
I think this sounds reasonable.
Reviewed-by: Brian Masney <[email protected]>
You should resend this out with git send-email and see what Bjorn says.
Brian
