Hi Thomas, Thanks, Avi
On Mon, Jul 15, 2019 at 3:37 PM Thomas Gleixner <[email protected]> wrote: > > Avi, > > On Mon, 15 Jul 2019, Avi Fishman wrote: > > > NPCM7XX_Tx_OPER GENMASK was wrong, > > That part is already fixed upstream: > > 9bdd7bb3a844 ("clocksource/drivers/npcm: Fix misuse of GENMASK macro") The automatic fix changed from GENMASK(3, 27) to GENMASK(27, 3) I reviewd again the code to check how it worked so far and saw that it should have been GENMASK(28, 27) - this is a different value than 9bdd7bb3a844 For our fortune this wrong value didn't effect the our final write to the register. But still this should be fixed. > > > npcm7xx_timer_oneshot() did wrong calculation > > That changelog is pretty unspecific. It does not tell what is wrong and > which consequences that has. Please be a bit more specific. OK I will fix > > Thanks, > > tglx -- Regards, Avi
