Allowing the fec to reset its PHY via the phy-reset-gpios devicetree property is deprecated. To improve developer awareness, generate a warning whenever the deprecated property is used.
Signed-off-by: Sven Van Asbroeck <[email protected]> --- drivers/net/ethernet/freescale/fec_main.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 38f10f7dcbc3..00e1b5e4ef71 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -3244,6 +3244,12 @@ static int fec_reset_phy(struct platform_device *pdev) else if (!gpio_is_valid(phy_reset)) return 0; + /* Recommended way to provide a PHY reset: + * - create a phy devicetree node, and link it to its fec (phy-handle) + * - add your reset gpio to the phy devicetree node + */ + dev_warn(&pdev->dev, "devicetree: phy-reset-gpios is deprecated\n"); + err = of_property_read_u32(np, "phy-reset-post-delay", &phy_post_delay); /* valid reset duration should be less than 1s */ if (!err && phy_post_delay > 1000) -- 2.17.1
