On Thu, Jul 25, 2019 at 10:48:42PM +0800, Kai-Heng Feng wrote: > at 15:55, Greg KH <gre...@linuxfoundation.org> wrote: > > > On Thu, Jul 18, 2019 at 05:25:22PM +0800, Kai-Heng Feng wrote: > > > The procfs provides many useful information for debugging, but it may be > > > too much for normal usage, routines like proc_get_sec_info() reports > > > various security related information. > > > > > > So disable it by defaultl. > > > > > > Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> > > > --- > > > drivers/staging/rtl8723bs/include/autoconf.h | 4 ---- > > > 1 file changed, 4 deletions(-) > > > > > > diff --git a/drivers/staging/rtl8723bs/include/autoconf.h > > > b/drivers/staging/rtl8723bs/include/autoconf.h > > > index 196aca3aed7b..8f4c1e734473 100644 > > > --- a/drivers/staging/rtl8723bs/include/autoconf.h > > > +++ b/drivers/staging/rtl8723bs/include/autoconf.h > > > @@ -57,9 +57,5 @@ > > > #define DBG 0 /* for ODM & BTCOEX debug */ > > > #endif /* !DEBUG */ > > > > > > -#ifdef CONFIG_PROC_FS > > > -#define PROC_DEBUG > > > -#endif > > > > What? Why? If you are going to do this, then rip out all of the code > > as well. > > Or make it a Kconfig option? Which one do you think is better?
No new config options please. > > And are you _sure_ you want to do this? > > Yes. The procfs of rtl8723bs is useful to Realtek to decode but not to > others. If no one else needs this, then rip out all of the code that uses it, not just the single #define. thanks, greg k-h
