Re: [PATCH V2 net-next 07/11] net: hns3: adds debug messages to identify eth down cause

[liuyonglong]

On 2019/7/27 6:18, Joe Perches wrote:
> On Fri, 2019-07-26 at 22:00 +0000, Saeed Mahameed wrote:
>> On Fri, 2019-07-26 at 11:24 +0800, Huazhong Tan wrote:
>>> From: Yonglong Liu <liuyongl...@huawei.com>
>>>
>>> Some times just see the eth interface have been down/up via
>>> dmesg, but can not know why the eth down. So adds some debug
>>> messages to identify the cause for this.
> []
>>> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
>> []
>>> @@ -459,6 +459,10 @@ static int hns3_nic_net_open(struct net_device
>>> *netdev)
>>>             h->ae_algo->ops->set_timer_task(priv->ae_handle, true);
>>>  
>>>     hns3_config_xps(priv);
>>> +
>>> +   if (netif_msg_drv(h))
>>> +           netdev_info(netdev, "net open\n");
>>> +
>>
>> to make sure this is only intended for debug, and to avoid repetition.
>> #define hns3_dbg(__dev, format, args...)                     \
>> ({                                                           \
>>      if (netif_msg_drv(h))                                   \
>>              netdev_info(h->netdev, format, ##args);         \
>> })
> 
>       netif_dbg(h, drv, h->netdev, "net open\n")
> 

Hi, Saeed && Joe:
For our cases, maybe netif_info() can be use for HNS3 drivers?
netif_dbg need to open dynamic debug options additional.