Andrew Morton napsal(a): > On Fri, 17 Aug 2007 00:08:58 +0200 Jesper Juhl <[EMAIL PROTECTED]> wrote: > >> Fix this tiny compiler warning in Moxa driver : >> drivers/char/mxser.c:386: warning: 'mxser_get_PCI_conf' declared 'static' >> but never defined >> when building without CONFIG_PCI. >> >> >> Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> >> --- >> >> drivers/char/mxser.c | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/char/mxser.c b/drivers/char/mxser.c >> index 2aee3fe..83b15b5 100644 >> --- a/drivers/char/mxser.c >> +++ b/drivers/char/mxser.c >> @@ -383,7 +383,9 @@ static int mxser_init(void); >> >> /* static void mxser_poll(unsigned long); */ >> static int mxser_get_ISA_conf(int, struct mxser_hwconf *); >> +#ifdef CONFIG_PCI >> static int mxser_get_PCI_conf(int, int, int, struct mxser_hwconf *); >> +#endif >> static void mxser_do_softint(struct work_struct *); >> static int mxser_open(struct tty_struct *, struct file *); >> static void mxser_close(struct tty_struct *, struct file *); >> > > mxser_get_PCI_conf() is defined before it is used anwyay. So that > prototype is a stupid waste of space and just adds problems. > > --- > a/drivers/char/mxser.c~mxser-fix-compiler-warning-when-building-withoug-config_pci > +++ a/drivers/char/mxser.c > @@ -383,7 +383,6 @@ static int mxser_init(void); > > /* static void mxser_poll(unsigned long); */ > static int mxser_get_ISA_conf(int, struct mxser_hwconf *); > -static int mxser_get_PCI_conf(int, int, int, struct mxser_hwconf *); > static void mxser_do_softint(struct work_struct *); > static int mxser_open(struct tty_struct *, struct file *); > static void mxser_close(struct tty_struct *, struct file *);
Acked-by: Jiri Slaby <[EMAIL PROTECTED]> thanks, -- http://www.fi.muni.cz/~xslaby/ Jiri Slaby faculty of informatics, masaryk university, brno, cz - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
