On Mon, 2019-07-29 at 10:29 +0800, Jia-Ju Bai wrote: > In iscsit_tpg_add_network_portal(), there is an if statement on line > 496 > to check whether tpg->tpg_tiqn is NULL: > if (tpg->tpg_tiqn) > > When tpg->tpg_tiqn is NULL, it is used on line 508: > pr_debug(..., tpg->tpg_tiqn->tiqn, ...); > > Thus, a possible null-pointer dereference may occur. > > To fix this bug, tpg->tpg_tiqn is checked before being used. > > This bug is found by a static analysis tool STCheck written by us.
I don't really think this is helpful. The first question is, is the implied might be NULL check correct? The tpg_tiqn is always set by a non-dummy driver and I think network configuration is only done for the non dummy driver, so I suspect the NULL check is wrong. Secondly even if the NULL check were correct, I think there's still a need for some debugging output, so the proposed patch also looks wrong. James
