strncmp(str, const, len) is error-prone.
We had better use newly introduced
str_has_prefix() instead of it.

Signed-off-by: Chuhong Yuan <[email protected]>
---
 kernel/sched/debug.c     | 2 +-
 kernel/sched/isolation.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
index f7e4579e746c..6a77bf51e4d3 100644
--- a/kernel/sched/debug.c
+++ b/kernel/sched/debug.c
@@ -103,7 +103,7 @@ static int sched_feat_set(char *cmp)
        int i;
        int neg = 0;
 
-       if (strncmp(cmp, "NO_", 3) == 0) {
+       if (str_has_prefix(cmp, "NO_")) {
                neg = 1;
                cmp += 3;
        }
diff --git a/kernel/sched/isolation.c b/kernel/sched/isolation.c
index ccb28085b114..cd5dfa93095d 100644
--- a/kernel/sched/isolation.c
+++ b/kernel/sched/isolation.c
@@ -143,13 +143,13 @@ static int __init housekeeping_isolcpus_setup(char *str)
        unsigned int flags = 0;
 
        while (isalpha(*str)) {
-               if (!strncmp(str, "nohz,", 5)) {
+               if (str_has_prefix(str, "nohz,")) {
                        str += 5;
                        flags |= HK_FLAG_TICK;
                        continue;
                }
 
-               if (!strncmp(str, "domain,", 7)) {
+               if (str_has_prefix(str, "domain,")) {
                        str += 7;
                        flags |= HK_FLAG_DOMAIN;
                        continue;
-- 
2.20.1

Reply via email to