Paolo Bonzini <[email protected]> writes:

> On 31/07/19 13:27, Wanpeng Li wrote:
>> From: Wanpeng Li <[email protected]>
>> 
>> kvm_set_pending_timer() will take care to wake up the sleeping vCPU which 
>> has pending timer, don't need to check this in apic_timer_expired() again.
>
> No, it doesn't.  kvm_make_request never kicks the vCPU.
>

Hm, but kvm_set_pending_timer() currently looks like:

void kvm_set_pending_timer(struct kvm_vcpu *vcpu)
{
        kvm_make_request(KVM_REQ_PENDING_TIMER, vcpu);
        kvm_vcpu_kick(vcpu);
}

-- 
Vitaly

Reply via email to