Hi Tzung-Bi, On 1/8/19 15:04, Tzung-Bi Shih wrote: > On Thu, Aug 1, 2019 at 6:59 PM Enric Balletbo i Serra > <[email protected]> wrote: >> >> Hi Tzung-Bi >> >> On 30/7/19 16:07, Tzung-Bi Shih wrote: >>> Hi Enric, >>> >>> I found it is error-prone to replace the EC_CMDS after updated. >>> Perhaps, we should introduce an intermediate file "cros_ec_trace.inc". >> >> I am not sure I get you here, a .inc? could you explain a bit more? >> > Manually generate .inc for all EC host commands: > sed ... include/linux/mfd/cros_ec_commands.h | awk ... >> drivers/platform/chrome/cros_ec_trace.inc > > In cros_ec_trace.c: > #include "cros_ec_trace.inc" >
Got it. I don't think this is a "kernel" way to do it. Also, I don't see a big value on doing this. > cros_ec_trace.inc: > #ifndef EC_CMDS > #define EC_CMDS \ > ... > #endif > > Override the whole file instead of replacing part of file to prevent > cut-and-paste error. > The way I see all this is that bulk updates of that file "shouldn't be allowed" or are not preferable. Ideally, _we_ (the maintainers), should take care on have cros_ec_commands and cros_ec_trace sync. For that, when someone sends a patch that touches the cros_ec_commands _we_ (them maintainers) should tell him to update also the cros_ec_trace file in the same patchset, and the script, is simply a helper to do that. Note that the cros_ec_trace needs an update to match current cros_ec_commands but I'm waiting to do the sync because we have a patchset that moves the cros_ec_commands.h file from include/linux/mfd to include/linux/platform_data. Once moved I'll sync the cros_ec_trace file with current cros_ec_commands Note also that actually, we want: - cros_ec_commands (kernel) sync with ec_commands (EC firmware) - cros_ec_commands (kernel) sync with cros_ec_trace (kernel) Hopefully we will have all sync soon. Thanks, ~ Enric
