On Tue, Jul 30, 2019 at 08:15:44PM +0800, [email protected] wrote: > diff --git a/arch/csky/mm/dma-mapping.c b/arch/csky/mm/dma-mapping.c > index 80783bb..3f1ff9d 100644 > --- a/arch/csky/mm/dma-mapping.c > +++ b/arch/csky/mm/dma-mapping.c > @@ -18,71 +18,52 @@ static int __init atomic_pool_init(void) > { > return dma_atomic_pool_init(GFP_KERNEL, pgprot_noncached(PAGE_KERNEL)); > } > -postcore_initcall(atomic_pool_init);
Please keep the postcore_initcall next to the function it calls. In this particular case I also plan to remove the function for 5.4 by moving it to the common dma code, so it is more important than just style.
