On Mon, 2019-08-05 at 17:30 +0200, Andrew Lunn wrote: > [External] > > On Mon, Aug 05, 2019 at 07:54:52PM +0300, Alexandru Ardelean wrote: > > This change implements retrieving all the error counters from the PHY. > > The PHY supports several error counters/stats. The `Mean Square Errors` > > status values are only valie when a link is established, and shouldn't be > > incremented. These values characterize the quality of a signal. > > I think you mean accumulated, not incremented?
accumulated sounds better; > > The rest of the error counters are self-clearing on read. > > Most of them are reports from the Frame Checker engine that the PHY has. > > > > Not retrieving the `LPI Wake Error Count Register` here, since that is used > > by the PHY framework to check for any EEE errors. And that register is > > self-clearing when read (as per IEEE spec). > > > > Signed-off-by: Alexandru Ardelean <[email protected]> > > --- > > drivers/net/phy/adin.c | 108 +++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 108 insertions(+) > > > > diff --git a/drivers/net/phy/adin.c b/drivers/net/phy/adin.c > > index a1f3456a8504..04896547dac8 100644 > > --- a/drivers/net/phy/adin.c > > +++ b/drivers/net/phy/adin.c > > @@ -103,6 +103,32 @@ static struct clause22_mmd_map clause22_mmd_map[] = { > > { MDIO_MMD_PCS, MDIO_PCS_EEE_WK_ERR, ADIN1300_LPI_WAKE_ERR_CNT_REG }, > > }; > > > > +struct adin_hw_stat { > > + const char *string; > > + u16 reg1; > > + u16 reg2; > > + bool do_not_inc; > > do_not_accumulate? or reverse its meaning, clear_on_read? do_not_accumulate works; there are only 4 regs that need this property set to true > > Andrew
