Re: [PATCH v8 16/21] soc/tegra: pmc: Add pmc wake support for tegra210

[Dmitry Osipenko]

09.08.2019 2:46, Sowjanya Komatineni пишет:
> This patch implements PMC wakeup sequence for Tegra210 and defines
> common used RTC alarm wake event.
> 
> Signed-off-by: Sowjanya Komatineni <skomatin...@nvidia.com>
> ---
>  drivers/soc/tegra/pmc.c | 98 
> +++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 98 insertions(+)
> 
> diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
> index 91c84d0e66ae..3aa71c28a10a 100644
> --- a/drivers/soc/tegra/pmc.c
> +++ b/drivers/soc/tegra/pmc.c
> @@ -58,6 +58,11 @@
>  #define  PMC_CNTRL_SYSCLK_POLARITY   BIT(10) /* sys clk polarity */
>  #define  PMC_CNTRL_MAIN_RST          BIT(4)
>  
> +#define PMC_WAKE_MASK                        0x0c
> +#define PMC_WAKE_LEVEL                       0x10
> +#define PMC_WAKE_STATUS                      0x14
> +#define PMC_SW_WAKE_STATUS           0x18
> +
>  #define DPD_SAMPLE                   0x020
>  #define  DPD_SAMPLE_ENABLE           BIT(0)
>  #define  DPD_SAMPLE_DISABLE          (0 << 0)
> @@ -87,6 +92,11 @@
>  
>  #define PMC_SCRATCH41                        0x140
>  
> +#define PMC_WAKE2_MASK                       0x160
> +#define PMC_WAKE2_LEVEL                      0x164
> +#define PMC_WAKE2_STATUS             0x168
> +#define PMC_SW_WAKE2_STATUS          0x16c
> +
>  #define PMC_SENSOR_CTRL                      0x1b0
>  #define  PMC_SENSOR_CTRL_SCRATCH_WRITE       BIT(2)
>  #define  PMC_SENSOR_CTRL_ENABLE_RST  BIT(1)
> @@ -1922,6 +1932,43 @@ static const struct irq_domain_ops 
> tegra_pmc_irq_domain_ops = {
>       .alloc = tegra_pmc_irq_alloc,
>  };
>  
> +static int tegra210_pmc_irq_set_wake(struct irq_data *data, unsigned int on)
> +{
> +     struct tegra_pmc *pmc = irq_data_get_irq_chip_data(data);
> +     unsigned int offset, bit;
> +     u32 value;
> +
> +     if (data->hwirq == ULONG_MAX)
> +             return 0;
> +
> +     offset = data->hwirq / 32;
> +     bit = data->hwirq % 32;
> +
> +     /* clear wake status */
> +     tegra_pmc_writel(pmc, 0, PMC_SW_WAKE_STATUS);
> +     tegra_pmc_writel(pmc, 0, PMC_SW_WAKE2_STATUS);
> +
> +     tegra_pmc_writel(pmc, 0, PMC_WAKE_STATUS);
> +     tegra_pmc_writel(pmc, 0, PMC_WAKE2_STATUS);
> +
> +     /* enable PMC wake */
> +     if (data->hwirq >= 32)
> +             offset = PMC_WAKE2_MASK;
> +     else
> +             offset = PMC_WAKE_MASK;
> +
> +     value = tegra_pmc_readl(pmc, offset);
> +
> +     if (on)
> +             value |= 1 << bit;
> +     else
> +             value &= ~(1 << bit);

Looks like a good case for utilizing of the BIT() macro here.