This is true but I believe afs_voltypes should be used in the afs_put_volume() and afs_deactivate_volume() enter() tracing.
If it will not be used for those calls then removal is correct.
Jeffrey Altman
On 8/9/2019 4:40 AM, YueHaibing wrote:
> fs/afs/volume.c:15:26: warning:
> afs_voltypes defined but not used [-Wunused-const-variable=]
>
> It is not used since commit d2ddc776a458 ("afs: Overhaul
> volume and server record caching and fileserver rotation")
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> fs/afs/volume.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/afs/volume.c b/fs/afs/volume.c
> index 1a41430..92ca5e2 100644
> --- a/fs/afs/volume.c
> +++ b/fs/afs/volume.c
> @@ -12,8 +12,6 @@
> unsigned __read_mostly afs_volume_gc_delay = 10;
> unsigned __read_mostly afs_volume_record_life = 60 * 60;
>
> -static const char *const afs_voltypes[] = { "R/W", "R/O", "BAK" };
> -
> /*
> * Allocate a volume record and load it up from a vldb record.
> */
>
<<attachment: jaltman.vcf>>
smime.p7s
Description: S/MIME Cryptographic Signature
