On Mon, 22 Jul 2019, Enric Balletbo i Serra wrote: > That's a driver to talk with the ChromeOS Embedded Controller via a > miscellaneous character device, it creates an entry in /dev for every > instance and implements basic file operations for communicating with the > Embedded Controller with an userspace application. The API is moved to > the uapi folder, which is supposed to contain the user space API of the > kernel. > > Note that this will replace current character device interface > implemented in the cros-ec-dev driver in the MFD subsystem. The idea is > to move all the functionality that extends the bounds of what MFD was > designed to platform/chrome subsystem. > > Signed-off-by: Enric Balletbo i Serra <[email protected]> > Acked-by: Andy Shevchenko <[email protected]> > Reviewed-by: Gwendal Grignou <[email protected]> > Tested-by: Gwendal Grignou <[email protected]> > --- > > Changes in v5: > - Prefix the versions strings with CROS_EC_DEV_VERSION (Gwendal) > > Changes in v4: None > Changes in v3: > - Fix 'linux/mfd/cros_ec.h' is not exported (reported by lkp) > > Changes in v2: > - Remove the list, and the lock, as are not needed (Greg Kroah-Hartman) > - Remove dev_info in probe, anyway we will see the chardev or not if the > probe fails (Greg Kroah-Hartman) > > drivers/mfd/cros_ec_dev.c | 4 +- > drivers/platform/chrome/Kconfig | 11 + > drivers/platform/chrome/Makefile | 1 + > drivers/platform/chrome/cros_ec_chardev.c | 252 ++++++++++++++++++ > .../uapi/linux/cros_ec_chardev.h | 9 +- > 5 files changed, 271 insertions(+), 6 deletions(-) > create mode 100644 drivers/platform/chrome/cros_ec_chardev.c > rename drivers/mfd/cros_ec_dev.h => include/uapi/linux/cros_ec_chardev.h > (80%)
For my own reference: Acked-for-MFD-by: Lee Jones <[email protected]> -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
