On Tue, Aug 13, 2019 at 10:14:11PM +0200, Andrew Lunn wrote: > > +static int rtl8211e_config_led(struct phy_device *phydev, int led, > > + struct phy_led_config *cfg) > > +{ > > + u16 lacr_bits = 0, lcr_bits = 0; > > + int oldpage, ret; > > + > > You should probably check that led is 0 or 1.
Actually this PHY has up to 3 LEDs, but yes, good point to validate the parameter. I'll wait a day or two for if there is other feedback and send a new version with the check. > Otherwise this looks good. Thanks for the reviews! Matthias