On 15/08/2019 08:46, Nishka Dasgupta wrote:
> Change return type of functions sysc_check_one_child() and
> sysc_check_children() from int to void as neither ever returns an error.
> Modify call sites of both functions accordingly.
> 
> Signed-off-by: Nishka Dasgupta <nishkadg.li...@gmail.com>

Acked-by: Roger Quadros <rog...@ti.com>

cheers,
-roger

> ---
> Changes in v4:
> - Merge into a single patch the two patches for sysc_check_one_child()
>   and sysc_check_children().
> Changes in v3:
> - Add patch for sysc_check_children().
> - Remove return statement in sysc_check_one_child().
> - Remove braces at call site.
> Changes in v2:
> - Remove error variable entirely.
> - Change return type of sysc_check_one_child().
> 
>  drivers/bus/ti-sysc.c | 22 ++++++----------------
>  1 file changed, 6 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
> index e6deabd8305d..a2eae8f36ef8 100644
> --- a/drivers/bus/ti-sysc.c
> +++ b/drivers/bus/ti-sysc.c
> @@ -615,8 +615,8 @@ static void sysc_check_quirk_stdout(struct sysc *ddata,
>   * node but children have "ti,hwmods". These belong to the interconnect
>   * target node and are managed by this driver.
>   */
> -static int sysc_check_one_child(struct sysc *ddata,
> -                             struct device_node *np)
> +static void sysc_check_one_child(struct sysc *ddata,
> +                              struct device_node *np)
>  {
>       const char *name;
>  
> @@ -626,22 +626,14 @@ static int sysc_check_one_child(struct sysc *ddata,
>  
>       sysc_check_quirk_stdout(ddata, np);
>       sysc_parse_dts_quirks(ddata, np, true);
> -
> -     return 0;
>  }
>  
> -static int sysc_check_children(struct sysc *ddata)
> +static void sysc_check_children(struct sysc *ddata)
>  {
>       struct device_node *child;
> -     int error;
> -
> -     for_each_child_of_node(ddata->dev->of_node, child) {
> -             error = sysc_check_one_child(ddata, child);
> -             if (error)
> -                     return error;
> -     }
>  
> -     return 0;
> +     for_each_child_of_node(ddata->dev->of_node, child)
> +             sysc_check_one_child(ddata, child);
>  }
>  
>  /*
> @@ -794,9 +786,7 @@ static int sysc_map_and_check_registers(struct sysc 
> *ddata)
>       if (error)
>               return error;
>  
> -     error = sysc_check_children(ddata);
> -     if (error)
> -             return error;
> +     sysc_check_children(ddata);
>  
>       error = sysc_parse_registers(ddata);
>       if (error)
> 

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

Reply via email to