On Wed, 2019-08-14 at 10:57 -0700, Florian Fainelli wrote: > [External] > > > > On 8/12/2019 4:23 AM, Alexandru Ardelean wrote: > > The ADIN PHYs support Energy Detect Powerdown mode, which puts the PHY into > > a low power mode when there is no signal on the wire (typically cable > > unplugged). > > This behavior is enabled by default, but can be disabled via device > > property. > > We could consider adding a PHY tunable, having this as a Device Tree > property amounts to putting a policy inside DT, which is frowned upon.
That would be interesting actually, and I would also prefer it over static DT. Maybe for this patch, I'll just enable EDPD by default and see about a tuna option. > > > Signed-off-by: Alexandru Ardelean <alexandru.ardel...@analog.com> > > Other than that, the code looks fine: > > Reviewed-by: Florian Fainelli <f.faine...@gmail.com>