On Fri 2019-08-09 10:56:04, Justin He (Arm Technology China) wrote: > > > > -----Original Message----- > > From: Andy Shevchenko <[email protected]> > > Sent: 2019年8月9日 18:52 > > To: Justin He (Arm Technology China) <[email protected]> > > Cc: Petr Mladek <[email protected]>; Andy Shevchenko > > <[email protected]>; Sergey Senozhatsky > > <[email protected]>; Geert Uytterhoeven > > <[email protected]>; Linux Kernel Mailing List <linux- > > [email protected]>; Thomas Gleixner <[email protected]>; Steven > > Rostedt (VMware) <[email protected]>; Kees Cook > > <[email protected]>; Shuah Khan <[email protected]>; Tobin C. > > Harding <[email protected]> > > Subject: Re: [PATCH 1/2] vsprintf: Prevent crash when dereferencing invalid > > pointers for %pD > > > > On Fri, Aug 9, 2019 at 4:28 AM Jia He <[email protected]> wrote: > > > > > > Commit 3e5903eb9cff ("vsprintf: Prevent crash when dereferencing > > invalid > > > pointers") prevents most crash except for %pD. > > > There is an additional pointer dereferencing before dentry_name. > > > > > > At least, vma->file can be NULL and be passed to printk %pD in > > > print_bad_pte, which can cause crash. > > > > > > This patch fixes it with introducing a new file_dentry_name. > > > > > > > Reviewed-by: Andy Shevchenko <[email protected]> > > > > Perhaps you need to add a Fixes tag > Thanks, Andy > Fixes: 3e5903eb9cff ("vsprintf: Prevent crash when dereferencing invalid > pointers")
I have added the Fixes tag and pushed the patch into printk.git, branch for-5.4. Thanks for the fix. Best Regards, Petr
