Hi Max, On Fri, Aug 16, 2019 at 11:09 AM Max Staudt <[email protected]> wrote: > ltc2990 will now use device_property_read_u32_array() instead of > of_property_read_u32_array() - allowing the use of software nodes > via fwnode_create_software_node(). > > This allows code using i2c_new_device() to specify a default > measurement mode for the LTC2990 via fwnode_create_software_node(). > > Signed-off-by: Max Staudt <[email protected]>
Thanks for your patch! Reviewed-by: Geert Uytterhoeven <[email protected]> One minor nit: as the driver no longer uses any of_*() symbols, you can replace #include <linux/of.h> by #include <linux/property.h>. > --- a/drivers/hwmon/ltc2990.c > +++ b/drivers/hwmon/ltc2990.c > @@ -206,7 +206,6 @@ static int ltc2990_i2c_probe(struct i2c_client *i2c, > int ret; > struct device *hwmon_dev; > struct ltc2990_data *data; > - struct device_node *of_node = i2c->dev.of_node; > > if (!i2c_check_functionality(i2c->adapter, I2C_FUNC_SMBUS_BYTE_DATA | > I2C_FUNC_SMBUS_WORD_DATA)) > @@ -218,9 +217,10 @@ static int ltc2990_i2c_probe(struct i2c_client *i2c, > > data->i2c = i2c; > > - if (of_node) { > - ret = of_property_read_u32_array(of_node, "lltc,meas-mode", > - data->mode, 2); > + if (dev_fwnode(&i2c->dev)) { > + ret = device_property_read_u32_array(&i2c->dev, > + "lltc,meas-mode", > + data->mode, 2); > if (ret < 0) > return ret; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
