Hi,
On 8/20/19 6:57 PM, Max Staudt wrote:
> Up until now, the pata_buddha driver would only check for cards on
> initcall time. Now, the kernel will call its probe function as soon
> as a compatible card is detected.
>
> v6: Only do the drvdata workaround for X-Surf (remove breaks otherwise)
> Style
>
> v5: Remove module_exit(): There's no good way to handle the X-Surf hack.
> Also include a workaround to save X-Surf's drvdata in case zorro8390
> is active.
>
> v4: Clean up pata_buddha_probe() by using ent->driver_data.
> Support X-Surf via late_initcall()
>
> v3: Clean up devm_*, implement device removal.
>
> v2: Rename 'zdev' to 'z' to make the patch easy to analyse with
> git diff --ignore-space-change
>
> Signed-off-by: Max Staudt <m...@enpas.org>
> ---
> drivers/ata/pata_buddha.c | 231
> +++++++++++++++++++++++++++-------------------
> 1 file changed, 138 insertions(+), 93 deletions(-)
>
> diff --git a/drivers/ata/pata_buddha.c b/drivers/ata/pata_buddha.c
> index 11a8044ff..9e1b57866 100644
> --- a/drivers/ata/pata_buddha.c
> +++ b/drivers/ata/pata_buddha.c
[...]
> +static struct zorro_driver pata_buddha_driver = {
> + .name = "pata_buddha",
> + .id_table = pata_buddha_zorro_tbl,
> + .probe = pata_buddha_probe,
> + .remove = pata_buddha_remove,
> + .driver = {
> + .suppress_bind_attrs = true,
I thought that we had agreed that this is not needed?
With that fixed:
Acked-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com>
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
