Hi Arnaud, I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master] [cannot apply to v5.3-rc6 next-20190829] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Arnaud-Pouliquen/rpmsg-core-add-API-to-get-message-length/20190829-222443 reproduce: # apt-get install sparse # sparse version: v0.6.1-rc1-7-g2b96cd8-dirty make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag Reported-by: kbuild test robot <[email protected]> sparse warnings: (new ones prefixed by >>) include/linux/sched.h:609:43: sparse: sparse: bad integer constant expression include/linux/sched.h:609:73: sparse: sparse: invalid named zero-width bitfield `value' include/linux/sched.h:610:43: sparse: sparse: bad integer constant expression include/linux/sched.h:610:67: sparse: sparse: invalid named zero-width bitfield `bucket_id' >> drivers/tty/rpmsg_tty.c:152:20: sparse: sparse: incompatible types in >> comparison expression (different type sizes): >> drivers/tty/rpmsg_tty.c:152:20: sparse: int * >> drivers/tty/rpmsg_tty.c:152:20: sparse: long * vim +152 drivers/tty/rpmsg_tty.c 132 133 static int rpmsg_tty_write(struct tty_struct *tty, const u8 *buf, int len) 134 { 135 struct rpmsg_tty_port *cport = tty->driver_data; 136 struct rpmsg_device *rpdev; 137 ssize_t msg_max_size, msg_size; 138 int ret; 139 u8 *tmpbuf; 140 141 /* If cts not set, the message is not sent*/ 142 if (!cport->cts) 143 return 0; 144 145 rpdev = cport->rpdev; 146 147 dev_dbg(&rpdev->dev, "%s: send msg from tty->index = %d, len = %d\n", 148 __func__, tty->index, len); 149 150 msg_max_size = rpmsg_get_mtu(rpdev->ept); 151 > 152 msg_size = min(len, msg_max_size); 153 tmpbuf = kzalloc(msg_size, GFP_KERNEL); 154 if (!tmpbuf) 155 return -ENOMEM; 156 157 memcpy(tmpbuf, buf, msg_size); 158 159 /* 160 * Try to send the message to remote processor, if failed return 0 as 161 * no data sent 162 */ 163 ret = rpmsg_trysendto(cport->d_ept, tmpbuf, msg_size, cport->data_dst); 164 kfree(tmpbuf); 165 if (ret) { 166 dev_dbg(&rpdev->dev, "rpmsg_send failed: %d\n", ret); 167 return 0; 168 } 169 170 return msg_size; 171 } 172 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
