From: Markus Elfring <[email protected]> Date: Tue, 3 Sep 2019 21:27:55 +0200
The brelse() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <[email protected]> --- fs/ufs/super.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/ufs/super.c b/fs/ufs/super.c index 1da0be667409..20799faa307a 100644 --- a/fs/ufs/super.c +++ b/fs/ufs/super.c @@ -574,8 +574,7 @@ static int ufs_read_cylinder_structures(struct super_block *sb) kfree (base); if (sbi->s_ucg) { for (i = 0; i < uspi->s_ncg; i++) - if (sbi->s_ucg[i]) - brelse (sbi->s_ucg[i]); + brelse(sbi->s_ucg[i]); kfree (sbi->s_ucg); for (i = 0; i < UFS_MAX_GROUP_LOADED; i++) kfree (sbi->s_ucpi[i]); -- 2.23.0
