On Wed, Sep 04, 2019 at 11:31:59AM -0600, Keith Busch wrote: > The namespace names must be unique for the lifetime of the subsystem. > This was accomplished by using their parent subsystems' instances which > was independent of the controllers connected to that subsystem. > > The consequence of that naming scheme meant that name prefixes given to > namespaces may match a controller from an unrelated subsystem. This has > understandbly invited confusion when examining device nodes. > > Ensure the namespace's subsystem instance never clashes with a > controller instance of another subsystem by transferring the instance > ownership to parent subsystem from the first controller discovered in > that subsystem.
Sanitity sounds a little exaggerated. The nvme naming isn't really that different except that the block devices uses number where say scsi uses letters. So maybe tone down that claim a bit, but otherwise the patch looks fine.
