> -----Original Message-----
> From: Jakub Kicinski <[email protected]>
> Sent: Friday, August 30, 2019 7:05 PM
> To: Haiyang Zhang <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; KY Srinivasan <[email protected]>; Stephen
> Hemminger <[email protected]>; [email protected]; vkuznets
> <[email protected]>; [email protected]; linux-
> [email protected]; Mark Bloch <[email protected]>
> Subject: Re: [PATCH net-next, 2/2] hv_netvsc: Sync offloading features to VF
> NIC
>
> On Fri, 30 Aug 2019 03:45:38 +0000, Haiyang Zhang wrote:
> > VF NIC may go down then come up during host servicing events. This
> > causes the VF NIC offloading feature settings to roll back to the
> > defaults. This patch can synchronize features from synthetic NIC to
> > the VF NIC during ndo_set_features (ethtool -K), and
> > netvsc_register_vf when VF comes back after host events.
> >
> > Signed-off-by: Haiyang Zhang <[email protected]>
> > Cc: Mark Bloch <[email protected]>
>
> If we want to make this change in behaviour we should change net_failover
> at the same time.
After checking the net_failover, I found it's for virtio based SRIOV, and very
different from what we did for Hyper-V based SRIOV.
We let the netvsc driver acts as both the synthetic (PV) driver and the
transparent
bonding master for the VF NIC. But net_failover acts as a master device on top
of both virtio PV NIC, and VF NIC. And the net_failover doesn't implemented
operations, like ndo_set_features.
So the code change for our netvsc driver cannot be applied to net_failover
driver.
I will re-submit my two patches (fixing the extra tab in the 1st one as you
pointed
out). Thanks!
- Haiyang
