‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Tuesday, September 17, 2019 2:53 PM, Baolin Wang <[email protected]> wrote:
> On Tue, 17 Sep 2019 at 17:12, Aurabindo Jayamohanan [email protected] wrote: > > > platform_get_resource() may return NULL. If it is so, return -ENXIO > > > > Signed-off-by: Aurabindo Jayamohanan [email protected] > > > > ------------------------------------------------------- > > > > drivers/spi/spi-sifive.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > diff --git a/drivers/spi/spi-sifive.c b/drivers/spi/spi-sifive.c > > index 93ec2c6cdbfd..67485067a694 100644 > > --- a/drivers/spi/spi-sifive.c > > +++ b/drivers/spi/spi-sifive.c > > @@ -308,6 +308,12 @@ static int sifive_spi_probe(struct platform_device > > *pdev) > > platform_set_drvdata(pdev, master); > > > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > > > > > - if (!res) { > > > > > > - dev_err(&pdev->dev, "no IOMEM resource found\\n"); > > > > > > - ret = -ENXIO; > > > > > > - goto put_master; > > > > > > - } > > > > > > Seems unnecessary, the devm_ioremap_resource() already validated if > the resource is available. > Okay, thanks for the headsup
