On Wed, Sep 11, 2019 at 10:17:59AM +0200, David Miller wrote: > From: Lars Poeschel <[email protected]> > Date: Tue, 10 Sep 2019 11:34:12 +0200 > > > +static int pn533_autopoll_complete(struct pn533 *dev, void *arg, > > + struct sk_buff *resp) > > +{ > > + u8 nbtg; > > + int rc; > > + struct pn532_autopoll_resp *apr; > > + struct nfc_target nfc_tgt; > > Need reverse christmas tree here.
See below. > > @@ -1534,6 +1655,7 @@ static int pn533_start_poll(struct nfc_dev *nfc_dev, > > struct pn533_poll_modulations *cur_mod; > > u8 rand_mod; > > int rc; > > + struct sk_buff *skb; > > Likewise. I will do a v8 with these changes soon.
