On Thu, Sep 19, 2019 at 11:10:14AM +0200, Miquel Raynal wrote: > Hi Markus, > > Markus Elfring <[email protected]> wrote on Wed, 18 Sep 2019 > 14:50:27 +0200: > > > From: Markus Elfring <[email protected]> > > Date: Wed, 18 Sep 2019 14:37:34 +0200 > > > > Simplify this function implementation by using a known wrapper function. > > > > This issue was detected by using the Coccinelle software. > > > > Signed-off-by: Markus Elfring <[email protected]> > > --- > > drivers/mtd/devices/st_spi_fsm.c | 8 +------- > > 1 file changed, 1 insertion(+), 7 deletions(-) > > > > diff --git a/drivers/mtd/devices/st_spi_fsm.c > > b/drivers/mtd/devices/st_spi_fsm.c > > index f4d1667daaf9..5bd1c44ae529 100644 > > --- a/drivers/mtd/devices/st_spi_fsm.c > > +++ b/drivers/mtd/devices/st_spi_fsm.c > > @@ -2034,13 +2034,7 @@ static int stfsm_probe(struct platform_device *pdev) > > > > platform_set_drvdata(pdev, fsm); > > > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > - if (!res) { > > - dev_err(&pdev->dev, "Resource not found\n"); > > - return -ENODEV; > > - } > > - > > - fsm->base = devm_ioremap_resource(&pdev->dev, res); > > + fsm->base = devm_platform_ioremap_resource(pdev, 0); > > if (IS_ERR(fsm->base)) { > > dev_err(&pdev->dev, > > "Failed to reserve memory region %pR\n", res); > > -- > > 2.23.0 > > > > > Is this even compiled tested? 'res' is not initialized anymore so you > can't use it in the error trace. I suppose you should even drop it from > the stack parameters.
You are responding to a email address/bot that is on a number of kernel developers "black list" as something to just totally ignore. I recommend you do the same if possible... greg k-h
