On Sun, Sep 22, 2019 at 02:07:21PM -0700, Andrii Nakryiko wrote: > On Fri, Sep 20, 2019 at 10:06 AM Kefeng Wang <wangkefeng.w...@huawei.com> > wrote: > > > > For kernel logging macro, pr_warning is completely removed and > > replaced by pr_warn, using pr_warn in tools lib bpf for symmetry > > to kernel logging macro, then we could drop pr_warning in the > > whole linux code. > > > > Cc: Alexei Starovoitov <a...@kernel.org> > > Cc: Daniel Borkmann <dan...@iogearbox.net> > > Cc: Martin KaFai Lau <ka...@fb.com> > > Cc: Song Liu <songliubrav...@fb.com> > > Cc: Yonghong Song <y...@fb.com> > > Cc: b...@vger.kernel.org > > Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> > > --- > > tools/lib/bpf/btf.c | 56 +-- > > tools/lib/bpf/btf_dump.c | 20 +- > > tools/lib/bpf/libbpf.c | 652 ++++++++++++++++---------------- > > tools/lib/bpf/libbpf_internal.h | 2 +- > > tools/lib/bpf/xsk.c | 4 +- > > 5 files changed, 363 insertions(+), 371 deletions(-) > > Thanks! This will allow to get rid of tons warnings from checkpatch.pl. > > Alexei, Daniel, can we take this through bpf-next tree once it's open?
I'd be fine with that, in fact, it probably should be in order to avoid merge conflicts since pr_warn{ing}() is used all over the place in libbpf. Kefeng would then however also need to include the original patch which adds the pr_warn() to tools in the first place. > Acked-by: Andrii Nakryiko <andr...@fb.com> > > [...]