On Fri, Sep 27, 2019 at 2:25 AM Rob Herring <[email protected]> wrote: > From: Robin Murphy <[email protected]> > > If we failed to translate a DMA address, at least show the offending > address rather than the uninitialised contents of the destination > argument. > > Signed-off-by: Robin Murphy <[email protected]> > Signed-off-by: Rob Herring <[email protected]>
Reviewed-by: Geert Uytterhoeven <[email protected]> > --- > drivers/of/address.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/of/address.c b/drivers/of/address.c > index 8e354d12fb04..53d2656c2269 100644 > --- a/drivers/of/address.c > +++ b/drivers/of/address.c > @@ -955,8 +955,8 @@ int of_dma_get_range(struct device_node *np, u64 > *dma_addr, u64 *paddr, u64 *siz > dmaaddr = of_read_number(ranges, naddr); > *paddr = of_translate_dma_address(np, ranges); > if (*paddr == OF_BAD_ADDR) { > - pr_err("translation of DMA address(%pad) to CPU address > failed node(%pOF)\n", Yeah, the %pad was wrong on 32-bit without CONFIG_PHYS_ADDR_T_64BIT. > - dma_addr, np); > + pr_err("translation of DMA address(%llx) to CPU address > failed node(%pOF)\n", > + dmaaddr, np); > ret = -EINVAL; > goto out; > } Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
