Em Thu, Sep 26, 2019 at 03:00:18PM -0700, Ian Rogers escreveu: > test_dir is assigned to the release array which is out-of-scope 3 lines > later. Extend the scope of the release array so that an out-of-scope > array isn't accessed. > Bug detected by clang's address sanitizer.
This one is really ironic, code to support using clang/llvm in perf is caught with a bug detected by clang's utilities ;-) Please next time try to use 'git blame' so as to add this: [root@quaco perf]# git tag --contains 07bc5c699a3d | grep ^v[[:digit:]] | sort --version-sort | head -1 v4.4 [root@quaco perf]# Cc: Wang Nan <[email protected]> Cc: [email protected] # v4.4+ Fixes: 07bc5c699a3d ("perf tools: Make fetch_kernel_version() publicly available") And help get noticed by the various backport bots out there. Thanks a lot, applied! - Arnaldo > Signed-off-by: Ian Rogers <[email protected]> > --- > tools/perf/util/llvm-utils.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/perf/util/llvm-utils.c b/tools/perf/util/llvm-utils.c > index 8d04e3d070b1..8b14e4a7f1dc 100644 > --- a/tools/perf/util/llvm-utils.c > +++ b/tools/perf/util/llvm-utils.c > @@ -233,14 +233,14 @@ static int detect_kbuild_dir(char **kbuild_dir) > const char *prefix_dir = ""; > const char *suffix_dir = ""; > > + /* _UTSNAME_LENGTH is 65 */ > + char release[128]; > + > char *autoconf_path; > > int err; > > if (!test_dir) { > - /* _UTSNAME_LENGTH is 65 */ > - char release[128]; > - > err = fetch_kernel_version(NULL, release, > sizeof(release)); > if (err) > -- > 2.23.0.444.g18eeb5a265-goog -- - Arnaldo
