On Tue, Oct 01, 2019 at 09:21:21AM -0700, Nick Desaulniers wrote: > > So you'd prefer I do something like the diff below? > > Yes, I find that diff preferable. Use __always_inline only when absolutely > necessary. Even then, it sounds like this is a workaround for one compiler, > so it should probably also have a comment. (I don't mind changing this for > all compilers).
I wondered about a comment, but I couldn't find a good place to put it. We basically need to say "If you're using explicit register variables in your function, then you should use __always_inline", but there are other functions too (such as arch/arm64/include/asm/vdso/gettimeofday.h) so a random comment buried in the atomic code doesn't feel very helpful to me. Will
