Hi Stephan, On Mon, Oct 07, 2019 at 10:50:21PM +0200, Stephan Gerhold wrote: > MMS345L is another first generation touch screen from Melfas, > which uses the same registers as MMS152. > > However, using I2C_M_NOSTART for it causes errors when reading: > > i2c i2c-0: sendbytes: NAK bailout. > mms114 0-0048: __mms114_read_reg: i2c transfer failed (-5) > > The driver works fine as soon as I2C_M_NOSTART is removed. > > Add a separate melfas,mms345l binding, and make use of I2C_M_NOSTART > only for MMS114 and MMS152. > > Signed-off-by: Stephan Gerhold <[email protected]>
Reviewed-by: Andi Shyti <[email protected]> just a nitpick in case you will resend it (but you don't need to). > - if (!i2c_check_functionality(client->adapter, > - I2C_FUNC_PROTOCOL_MANGLING)) { > + type = (enum mms_type)device_get_match_data(&client->dev); you don't need any cast here. Thanks, Andi
