On Mon, Oct 07, 2019 at 04:47:02PM +0100, Will Deacon wrote: > 'refcount_error_report()' has no callers. Remove it.
Seems like this could be collapsed into patch 8? Either way: Acked-by: Kees Cook <[email protected]> -Kees > > Cc: Ingo Molnar <[email protected]> > Cc: Elena Reshetova <[email protected]> > Cc: Peter Zijlstra <[email protected]> > Cc: Ard Biesheuvel <[email protected]> > Cc: Kees Cook <[email protected]> > Signed-off-by: Will Deacon <[email protected]> > --- > include/linux/kernel.h | 7 ------- > kernel/panic.c | 11 ----------- > 2 files changed, 18 deletions(-) > > diff --git a/include/linux/kernel.h b/include/linux/kernel.h > index d83d403dac2e..09f759228e3f 100644 > --- a/include/linux/kernel.h > +++ b/include/linux/kernel.h > @@ -328,13 +328,6 @@ extern int oops_may_print(void); > void do_exit(long error_code) __noreturn; > void complete_and_exit(struct completion *, long) __noreturn; > > -#ifdef CONFIG_ARCH_HAS_REFCOUNT > -void refcount_error_report(struct pt_regs *regs, const char *err); > -#else > -static inline void refcount_error_report(struct pt_regs *regs, const char > *err) > -{ } > -#endif > - > /* Internal, do not use. */ > int __must_check _kstrtoul(const char *s, unsigned int base, unsigned long > *res); > int __must_check _kstrtol(const char *s, unsigned int base, long *res); > diff --git a/kernel/panic.c b/kernel/panic.c > index 47e8ebccc22b..10d05fd4f9c3 100644 > --- a/kernel/panic.c > +++ b/kernel/panic.c > @@ -670,17 +670,6 @@ EXPORT_SYMBOL(__stack_chk_fail); > > #endif > > -#ifdef CONFIG_ARCH_HAS_REFCOUNT > -void refcount_error_report(struct pt_regs *regs, const char *err) > -{ > - WARN_RATELIMIT(1, "refcount_t %s at %pB in %s[%d], uid/euid: %u/%u\n", > - err, (void *)instruction_pointer(regs), > - current->comm, task_pid_nr(current), > - from_kuid_munged(&init_user_ns, current_uid()), > - from_kuid_munged(&init_user_ns, current_euid())); > -} > -#endif > - > core_param(panic, panic_timeout, int, 0644); > core_param(panic_print, panic_print, ulong, 0644); > core_param(pause_on_oops, pause_on_oops, int, 0644); > -- > 2.23.0.581.g78d2f28ef7-goog > -- Kees Cook
