On Tue, Oct 15, 2019 at 12:25 AM kbuild test robot <l...@intel.com> wrote:

> smatch warnings:
> drivers/iio/accel/bma400_core.c:422 bma400_set_accel_oversampling_ratio() 
> warn: unsigned 'acc_config' is never less than zero.

>    420                  ret = regmap_read(data->regmap, 
> BMA400_ACC_CONFIG0_REG,
>    421                                    &acc_config);
>  > 422                  if (acc_config < 0)
>    423                          return acc_config;

Obvious typo, has to be if (ret < 0)

>    424
>    425                  ret = regmap_write(data->regmap, 
> BMA400_ACC_CONFIG0_REG,
>    426                                     (acc_config & ~BMA400_LP_OSR_MASK) 
> |
>    427                                     (val << BMA400_LP_OSR_SHIFT));
>    428                  if (ret < 0) {
>    429                          dev_err(data->dev, "Failed to write out OSR");
>    430                          return ret;
>    431                  }



-- 
With Best Regards,
Andy Shevchenko

Reply via email to