Em Wed, Oct 16, 2019 at 04:38:45PM +0800, Yunfeng Ye escreveu: > The memory @orig_flags is allocated by strdup(), it is freed on the > normal path, but leak to free on the error path.
Are you using some tool to find out these problems? Or is it just visual inspection? - Arnaldo > Fix this by adding free(orig_flags) on the error path. > > Signed-off-by: Yunfeng Ye <yeyunf...@huawei.com> > --- > tools/perf/builtin-kmem.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/perf/builtin-kmem.c b/tools/perf/builtin-kmem.c > index 1e61e353f579..9661671cc26e 100644 > --- a/tools/perf/builtin-kmem.c > +++ b/tools/perf/builtin-kmem.c > @@ -691,6 +691,7 @@ static char *compact_gfp_flags(char *gfp_flags) > new = realloc(new_flags, len + strlen(cpt) + 2); > if (new == NULL) { > free(new_flags); > + free(orig_flags); > return NULL; > } > > -- > 2.7.4.3 -- - Arnaldo