Hi,
On 21/10/2019 07:41:01+0200, Andreas Kemnade wrote:
> +#if 0
> +/*
> + * REVISIT when implementing charger:
> + * according to some other implementation it needs special treatment,
> + * inverted but experiments seem not to confirm that.
> + */
> + [RN5T618_IRQ_CHG] = {
> + .reg_offset = 0,
> + .mask = (1 << 6),
> + }
> +#endif
Please avoid submitting dead code.
> +};
> +
> +static const struct regmap_irq_chip rc5t619_irq_chip = {
> + .name = "rc5t619",
> + .irqs = rc5t619_irqs,
> + .num_irqs = ARRAY_SIZE(rc5t619_irqs),
> + .num_regs = 1,
> + .status_base = RN5T618_INTMON,
> + .mask_base = RN5T618_INTEN,
> + .mask_invert = true,
> +};
> +
> +int rn5t618_irq_init(struct rn5t618 *rn5t618)
> +{
> + const struct regmap_irq_chip *irq_chip;
> + int ret;
> +
> + if (!rn5t618->chip_irq)
> + return 0;
> +
> + switch (rn5t618->variant) {
> + case RC5T619:
> + irq_chip = &rc5t619_irq_chip;
> + break;
> +
> + /* TODO: check irq definitions for other variants */
> +
> + default:
> + irq_chip = NULL;
> + break;
> + }
> +
> + if (!irq_chip) {
> + dev_err(rn5t618->dev, "no IRQ definition known for variant\n");
> + return -ENOENT;
> + }
> +
> + ret = devm_regmap_add_irq_chip(rn5t618->dev, rn5t618->regmap,
> + rn5t618->chip_irq,
> + IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
> + 0, irq_chip, &rn5t618->irq_data);
> + if (ret != 0) {
> + dev_err(rn5t618->dev, "Failed to register IRQ chip\n");
> + return ret;
> + }
> +
> + return 0;
> +}
> diff --git a/include/linux/mfd/rn5t618.h b/include/linux/mfd/rn5t618.h
> index d62ef48060b5..4d680f34ad2f 100644
> --- a/include/linux/mfd/rn5t618.h
> +++ b/include/linux/mfd/rn5t618.h
> @@ -242,9 +242,27 @@ enum {
> RC5T619,
> };
>
> +
> +/* RN5T618 IRQ definitions */
> +enum {
> + RN5T618_IRQ_SYS,
> + RN5T618_IRQ_DCDC,
> + RN5T618_IRQ_RTC,
> + RN5T618_IRQ_ADC,
> + RN5T618_IRQ_GPIO,
> + RN5T618_IRQ_CHG,
> + RN5T618_NR_IRQS,
> +};
> +
> +
Spurious blank line.
> struct rn5t618 {
> struct regmap *regmap;
> + struct device *dev;
> long variant;
> +
> + int chip_irq;
> + struct regmap_irq_chip_data *irq_data;
> };
>
> +extern int rn5t618_irq_init(struct rn5t618 *rn5t618);
> #endif /* __LINUX_MFD_RN5T618_H */
> --
> 2.11.0
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
