On 2020-04-28 03:20, Colin King wrote: > From: Colin Ian King <[email protected]> > > The bitfields mpi_fw_dump_reading and mpi_fw_dumped are currently signed > which is not recommended as the representation is an implementation defined > behaviour. Fix this by making the bit-fields unsigned ints. > > Fixes: cbb01c2f2f63 ("scsi: qla2xxx: Fix MPI failure AEN (8200) handling") > Signed-off-by: Colin Ian King <[email protected]> > --- > drivers/scsi/qla2xxx/qla_def.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h > index daa9e936887b..172ea4e5887d 100644 > --- a/drivers/scsi/qla2xxx/qla_def.h > +++ b/drivers/scsi/qla2xxx/qla_def.h > @@ -4248,8 +4248,8 @@ struct qla_hw_data { > int fw_dump_reading; > void *mpi_fw_dump; > u32 mpi_fw_dump_len; > - int mpi_fw_dump_reading:1; > - int mpi_fw_dumped:1; > + unsigned int mpi_fw_dump_reading:1; > + unsigned int mpi_fw_dumped:1; > int prev_minidump_failed; > dma_addr_t eft_dma; > void *eft;
Reviewed-by: Bart Van Assche <[email protected]>
